Switch RecursionId to any #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jakebailey
commented
Aug 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the RecursionId type to prevent data corruption from uint64 to uint32 conversions. The change replaces a structured approach with an any-based implementation that preserves the full precision of ID values.
- Removes the complex
RecursionIdKindenum and structuredRecursionIdwith separate kind/id fields - Introduces a generic
asRecursionIdfunction to constrain valid types while usinganyfor storage - Updates all usage sites to use the simplified API
sheetalkamat
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is subtly wrong because some of the IDs are
uint64and are being converted touint32. In long running programs, this would manifest as very strange behavior.I don't think we actually need anything special here;
anyis enough to do the right thing and avoids making that same mistake in the same amount of space as it would take to expand the struct to have auint64value + padding.